Opened 8 months ago

Closed 8 months ago

#1318 closed defect (invalid)

Jabber: private messages from conferences are not shown

Reported by: kuglydoo Owned by: ghazan
Priority: major Milestone:
Component: jabber Version: 0.95.6
Severity: bug Keywords:
Cc:

Description

Miranda fails to show a private message from MUC because it mistakenly believes that it is an invitation.

Outgoing message:

<message type="chat" to="test@conference.service/username" id="mir_25">
<body>Private message.</body>
</message>

Incoming message:

<message from="test@conference.service/username" to="username@service/resource" xml:lang="en" type="chat" id="mir_25">
<body>Private message.</body>
<x xmlns="http://jabber.org/protocol/muc#user" />
</message>

I believe that there should be some additional checks around http://trac.miranda-ng.org/browser/trunk/protocols/JabberG/src/jabber_thread.cpp#L1295 instead of unconditional isChatRoomInvitation = TRUE.

Change History (2)

comment:1 Changed 8 months ago by wishmaster

But there is a check in line 1295:

HXML inviteNode = XmlGetChild(xNode, L"invite");
if (inviteNode != NULL)

There is no such invite node in the messages you posted.

Last edited 8 months ago by wishmaster (previous) (diff)

comment:2 Changed 8 months ago by kuglydoo

  • Resolution set to invalid
  • Status changed from new to closed

There

Note: See TracTickets for help on using tickets.